[ 
https://issues.apache.org/jira/browse/MCOMPILER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733771#comment-17733771
 ] 

ASF GitHub Bot commented on MCOMPILER-397:
------------------------------------------

ebourg commented on PR #193:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/193#issuecomment-1595767468

   This is incomplete, the path separators have to be normalized too.




> Use relative paths in jpms.args to make the builds reproducible
> ---------------------------------------------------------------
>
>                 Key: MCOMPILER-397
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-397
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.8.1
>            Reporter: Emmanuel Bourg
>            Priority: Major
>              Labels: reproducibility
>
> The {{jpms.args}} file generated since the version 3.7 contains absolute 
> paths, for example here is the file generated for jaxb-core:
> {code}
> --add-modules
> java.xml.bind
> --upgrade-module-path
> /home/ebourg/jaxb/jaxb-ri/core/target/endorsed
> {code}
> The absolute path affects the reproducibility of the builds. Someone else 
> rebuilding the project is unlikely to have the same base path and will not 
> get a byte identical artifact. I suggest using a relative path instead 
> (starting at the root of the project or at the root of the module) and 
> normalizing the path separators (such that builds on Windows and Unix 
> generate the same file).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to