[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730506#comment-17730506 ]
ASF GitHub Bot commented on MASSEMBLY-791: ------------------------------------------ elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1222887655 ########## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ########## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends AbstractMojo implements Assem @Parameter private String overrideGroupName; + /** + * Override of umask. Review Comment: If this shows up in user docs, better description is needed. If it doesn't no description is needed. ########## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ########## @@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource { * @return Override group name. */ String getOverrideGroupName(); + + /** + * @return Override umask. + */ + Integer getOverrideUmask(); Review Comment: Adding a method to an interface is an incompatible change in public API that can break existing code. In Java 8 this should have a default implementation to avoid that. ########## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ########## @@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource { * @return Override group name. */ String getOverrideGroupName(); + + /** + * @return Override umask. Review Comment: What is an override umask? The api doc should explain > fileMode not set in dependencySet creating format tar.gz > -------------------------------------------------------- > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions > Affects Versions: 2.6 > Environment: Linux and Windows > Reporter: Rick Poleshuck > Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > <dependencySets> > <dependencySet> > <includes> > <include>com.company:dependency-artifact</include> > </includes> > <unpack>true</unpack> > <unpackOptions> > <includes> > <include>*.py</include> > </includes> > </unpackOptions> > <outputDirectory/> > <fileMode>0750</fileMode> > <directoryMode>0750</directoryMode> > </dependencySet> > </dependencySets> > </ -- This message was sent by Atlassian Jira (v8.20.10#820010)