CrazyHZM commented on code in PR #1099: URL: https://github.com/apache/maven/pull/1099#discussion_r1217499128
########## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ########## @@ -422,6 +436,106 @@ public String toString() { } } + /** + * Represents a combination in the version item list. + * It is usually a combination of a string and a number, with the string first and the number second + */ + private static class CombinationItem implements Item { + + StringItem stringValue; + + Item digitValue; + + CombinationItem(String v) { + int index = 0; + for (int i = 0; i < v.length(); i++) { + char c = v.charAt(i); + if (Character.isDigit(c)) { Review Comment: I looked at the documentation and it doesn't seem to conflict with what the documentation says . This is just for combinations, like sp.1, sp-1, and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org