[
http://jira.codehaus.org/browse/WAGON-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_99276
]
Jochen Wiedmann commented on WAGON-82:
--------------------------------------
I strongly disagree with the solutions discussed so far. IMO, they are all
basically hacks.
IMO, the actual problem is, that not the wagon provider itself decides on the
use of proxies, but the DefaultWagonManager. It does so, based on the
"protocol". A far better solution would be, either
- to give the proxy settings to the wagon provider and let him decide, whether
to use them or not, or.
The best way to do this would be a new interface, for example
package org.apache.maven.wagon;
public interface ProxyProvider {
/* Returns a proxy for the given protocol, if available, or null.
*/
public ProxyInfo getProxyForProtocol(String protocol);
}
The proxy provider might have a setter for ProxyProvider, which the
DefaultWagonManager might invoke.
- to introduce a new method (for example isProxyInfoRequired(String url)),
which the DefaultWagonManager
uses to query the wagon provider, whether it wants proxy settings or not.
> wagon-webdav does not set http-proxy correctly
> ----------------------------------------------
>
> Key: WAGON-82
> URL: http://jira.codehaus.org/browse/WAGON-82
> Project: wagon
> Issue Type: Bug
> Components: wagon-webdav
> Affects Versions: 1.0-beta-2
> Environment: any system
> Reporter: Marc Wilhelm
> Priority: Blocker
> Attachments: wagon-webdav.patch
>
>
> Webdav connections through a http-proxy are currently not possible.
> The webdav provider opens first a connection to the target system and checks
> after this, if a proxy should be used.
> To fix this in the method
> "org.apache.maven.wagon.providers.webdav.WebdavWagon#openConnection()" the
> call "webdavResource = new CorrectedWebdavResource( httpURL );" must be
> changed into "webdavResource = new CorrectedWebdavResource( );" and after
> configuring the http-proxy the method call
> "webdavResource.setHttpURL(httpURL);" must be added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
