[
https://issues.apache.org/jira/browse/MNG-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711110#comment-17711110
]
ASF GitHub Bot commented on MNG-7754:
-------------------------------------
kwin commented on code in PR #1079:
URL: https://github.com/apache/maven/pull/1079#discussion_r1163313730
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DeprecatedCoreExpressionValidator.java:
##########
@@ -49,21 +52,32 @@ class DeprecatedCoreExpressionValidator extends
AbstractMavenPluginParametersVal
DEPRECATED_CORE_PARAMETERS = deprecatedCoreParameters;
}
+ @Inject
+ DeprecatedCoreExpressionValidator(PluginValidationManager
pluginValidationManager) {
+ super(pluginValidationManager);
+ }
+
@Override
protected String getParameterLogReason(Parameter parameter) {
- return "is deprecated core expression; " +
DEPRECATED_CORE_PARAMETERS.get(parameter.getDefaultValue());
+ return "uses deprecated parameter expression; " +
DEPRECATED_CORE_PARAMETERS.get(parameter.getDefaultValue());
Review Comment:
```suggestion
return "uses deprecated parameter expression '" +
parameter.getDefaultValue() + "': "
DEPRECATED_CORE_PARAMETERS.get(parameter.getDefaultValue());
```
> Improvement and extension of plugin validation
> ----------------------------------------------
>
> Key: MNG-7754
> URL: https://issues.apache.org/jira/browse/MNG-7754
> Project: Maven
> Issue Type: Task
> Components: Core
> Affects Versions: 3.9.1
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.2, 4.0.0-alpha-6, 4.0.0
>
>
> Some users when see following warning:
> {noformat}
> [INFO] --- remote-resources:1.7.0:process (process-resource-bundles) @ maven
> ---
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it
> instead. {noformat}
> on their console, immediately grep their {{$HOME}} to find out that they DO
> HAVE afore mentioned string present in their {{{}settings.xml{}}}, and then
> scratch their head how to get rid of it.
> Hence, we should improve error message – at least add some clue that message
> targets given Mojo developers (as message appears immediately under Mojo
> execution log message) and not users. Best users could do is nag Mojo
> developers, and not us, to make message disappear.
> Improvements:
> * report at end, instead multiple times same warning (for reactor builds)
> * possibility to suppress validation
> * new check: maven-compat, maven2, p-c-d, mixed maven verions,, wrong scopes
> (similar as m-p-p does on build time)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
