gnodet commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1500587863
I think we should make the `rootdir` property available from the _project_
rather than from the _session_. If we want to support über-aggregations, we
should prepare for each project to have a different _rootdir_.
The current `session.rootdir` would only be the `rootdir` for the _top
project_.
Consider the following:
```
a
|- b
| \- c
\- d
\- e
```
where _b_ and _d_ are GitHub repositories and _a_ is a project aggregating
_b_ and _d_. In this case, _c_ rootdir should point to _b_ and _e_ rootdir
should point to _d_. If we don't do this, projects would be build differently
because the rootdir would point to _a_, which could be really bad.
I'm going to add a `getRootdir()` on `Project` and make sure that this one
is used when interpolating projects or injecting mojos. This would not affect
early usage of the `rootdir` property obviously.
The other possibility is to clearly document the limitation and that
projects using `rootdir` may not be properly aggregated (which is the case
currently for projects using the `maven.multiModuleProjectDirectory` or other
mechanisms), but if that could be fixed as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
