[
http://jira.codehaus.org/browse/NMAVEN-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_99101
]
Shane Isbell commented on NMAVEN-73:
------------------------------------
Thanks Evan! The patch looks great. A few comments: 1) The TesterMojo imports
the DefaultStreamConsumer, which is in the impl package. As a general rule, no
impl packages should exist in the Mojos, so either the the
DefaultStreamConsumer should be moved to a public package or should be gotten
from a Factory. Also we need to JavaDoc document when we use
CommandExecutor.Factory.createCommandExecutor(stdOut, stdErr); instead of
CommandExecutor.Factory.createDefaultCommandExecutor because it is not clear
from looking at the names.
The third issue, which does not need to be addressed now, but I just want to
comment on it so I don't forget. We will probably want to have multiple methods
on the DefaultStreamConsumer, such as setMavenLogger, setJdkLogger,
setPlexusLogger, etc. By setting the JDK logger, I can add a sockethandler and
get all the test results (as well as other plugin results) to the IDE. So this
patch hits a general issue as well.
> NUnit output is inconsistent with maven-test-plugin output
> ----------------------------------------------------------
>
> Key: NMAVEN-73
> URL: http://jira.codehaus.org/browse/NMAVEN-73
> Project: NMaven
> Issue Type: Improvement
> Environment: Maven 2.0.4 with NMaven 0.14-SNAPSHOT
> Reporter: Evan Worley
> Priority: Minor
> Attachments: testPatch.txt, testPatch.txt
>
>
> I was thinking there would be some value in doing some work on the nunit
> plugin to add some output similar to the junit plugin. Currently when nunit
> tests run, all the output is logged to file. It is not too much fun when
> your tests run for a few minutes, you see nothing. Here is a junit output vs
> nunit output comparison
> -- JUNIT --
> Running package1.TestClass1
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec
> Running package2.TestClass2
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
> .
> .
> .
> Results :
> Tests run: 139, Failures: 0, Errors: 0, Skipped: 0
> -- NUNIT --
> NMAVEN-040-000: Executed command: Commandline = nunit-console C:\dev\project
> \main\component\target\test-assemblies\Namespace.Artifact.dll /out
> {SOME_OUTPUT_FILE} /err {SOME_OUTPUT_FILE}, Result = 0
> The nmaven test plugin should capture the stdout/stderr from nunit and format
> is similar to junit. These inconsistencies are especially noticed in
> environments where you build the same component in java and C#. Switching
> from the java to C# build seems like a whole new world, instead of simply a
> new language
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
