[
https://issues.apache.org/jira/browse/MNG-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708750#comment-17708750
]
ASF GitHub Bot commented on MNG-7754:
-------------------------------------
michael-o commented on code in PR #1079:
URL: https://github.com/apache/maven/pull/1079#discussion_r1158199434
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -70,8 +72,12 @@ private ValidationLevel
validationLevel(RepositorySystemSession session) {
try {
return ValidationLevel.valueOf(level.toUpperCase(Locale.ENGLISH));
} catch (IllegalArgumentException e) {
- throw new IllegalArgumentException(
- "Invalid value specified for property " +
MAVEN_PLUGIN_VALIDATION_KEY + ": '" + level + "'", e);
+ logger.warn(
+ "Invalid value specified for property '{}': '{}'.
Supported values are (case insensitive): {}",
Review Comment:
The single quotes aren't necessary after then colon. That's the purpose of
the colon.
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -169,10 +169,10 @@ public void
reportSessionCollectedValidationIssues(MavenSession mavenSession) {
}
logger.warn("");
logger.warn(
- "To fix these issues, please upgrade listed plugins, or
notify their maintainers about these issues.");
+ "To fix these issues, please upgrade above listed plugins,
or, notify their maintainers about reported issues.");
logger.warn("");
logger.warn(
- "To get more or less details, use
'maven.plugin.validation' user property with one of the values: 'disabled',
'verbose' or (implied) 'default'");
+ "For more or less details in this report, use
'maven.plugin.validation' user property with one of the values: 'disabled',
'verbose' or (implied) 'default'");
Review Comment:
description after value:
...'verbose' or 'default' (implied)"
> Improvement and extension of plugin validation
> ----------------------------------------------
>
> Key: MNG-7754
> URL: https://issues.apache.org/jira/browse/MNG-7754
> Project: Maven
> Issue Type: Task
> Components: Core
> Affects Versions: 3.9.1
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.2, 4.0.0-alpha-6, 4.0.0
>
>
> Some users when see following warning:
> {noformat}
> [INFO] --- remote-resources:1.7.0:process (process-resource-bundles) @ maven
> ---
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it
> instead. {noformat}
> on their console, immediately grep their {{$HOME}} to find out that they DO
> HAVE afore mentioned string present in their {{{}settings.xml{}}}, and then
> scratch their head how to get rid of it.
> Hence, we should improve error message – at least add some clue that message
> targets given Mojo developers (as message appears immediately under Mojo
> execution log message) and not users. Best users could do is nag Mojo
> developers, and not us, to make message disappear.
> Improvements:
> * report at end, instead multiple times same warning (for reactor builds)
> * possibility to suppress validation
> * new check: maven-compat, maven2, p-c-d, mixed maven verions,, wrong scopes
> (similar as m-p-p does on build time)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
