elharo commented on code in PR #128:
URL: https://github.com/apache/maven-archetype/pull/128#discussion_r1157464745
##########
archetype-common/src/test/java/org/apache/maven/archetype/common/TestPomManager.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.maven.archetype.common;
+
+/*
Review Comment:
Just move it
##########
archetype-common/src/main/java/org/apache/maven/archetype/common/util/PomUtils.java:
##########
@@ -127,7 +129,16 @@ public static boolean addNewModule( String artifactId,
Reader fileReader, Writer
tf.setAttribute( XMLConstants.ACCESS_EXTERNAL_STYLESHEET, "" );
tf.setAttribute( "indent-number", 2 );
- Transformer tr = tf.newTransformer();
+ final Transformer tr;
Review Comment:
initialize and declare on the same line; make the try block bigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
