slawekjaranowski commented on code in PR #274:
URL: https://github.com/apache/maven-resolver/pull/274#discussion_r1153710418


##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -159,6 +159,51 @@ public final class ConfigurationProperties {
      */
     public static final boolean DEFAULT_HTTP_PREEMPTIVE_AUTH = false;
 
+    /**
+     * Should HTTP client reuse connections (in other words, pool connections) 
or not?
+     *
+     * @see #DEFAULT_HTTP_REUSE_CONNECTIONS
+     * @since 1.9.8
+     */
+    public static final String HTTP_REUSE_CONNECTIONS = PREFIX_CONNECTOR + 
"http.reuseConnections";
+
+    /**
+     * The default value to use if {@link #HTTP_REUSE_CONNECTIONS} isn't set 
(true).
+     *
+     * @since 1.9.8
+     */
+    public static final boolean DEFAULT_HTTP_REUSE_CONNECTIONS = true;
+
+    /**
+     * Time to live in seconds for an HTTP connection, after that time, the 
connection will be dropped.
+     *
+     * @see #DEFAULT_HTTP_CONNECTION_MAX_TTL
+     * @since 1.9.8
+     */
+    public static final String HTTP_CONNECTION_MAX_TTL = PREFIX_CONNECTOR + 
"http.connectionMaxTtl";
+
+    /**
+     * The default value to use if {@link #HTTP_CONNECTION_MAX_TTL} isn't set 
(600 seconds).
+     *
+     * @since 1.9.8
+     */
+    public static final int DEFAULT_HTTP_CONNECTION_MAX_TTL = 600;

Review Comment:
   I still think that 300 will be better - will be the same as is in Wagon - I 
don't see reason to change it.
   Even more - users on system like Azure will must set additional 
configuration parameter - now it is not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to