[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706355#comment-17706355 ]
ASF GitHub Bot commented on MNG-7038: ------------------------------------- gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151777611 ########## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ########## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class<?> type) throws ExpressionEvaluationEx MojoDescriptor mojoDescriptor = mojoExecution.getMojoDescriptor(); - if ("localRepository".equals(expression)) { + if ("rootdir".equals(expression) || "session.rootdir".equals(expression)) { + value = session.getRootdir(); + } else if ("topdir".equals(expression) || "session.topdir".equals(expression)) { + value = session.getTopdir(); Review Comment: @michael-o fwiw, the addition of `rootdir` and `topdir` was done to be in line with `basedir`, so maybe we should deprecate that one ? I'll raise a PR to clean at least the v4 expression evaluator, as plugins will have to migrate to switch to it anyway. > Introduce public property to point to a root directory of (multi-module) > project > -------------------------------------------------------------------------------- > > Key: MNG-7038 > URL: https://issues.apache.org/jira/browse/MNG-7038 > Project: Maven > Issue Type: Improvement > Reporter: Envious Guest > Priority: Major > Fix For: Issues to be reviewed for 4.x > > > This is a request to expose a property *maven.multiModuleProjectDirectory* > which is currently internal (or introduce a brand new one with analogous > functionality). > * For a single-module project, its value should be same as *project.basedir* > * For multi-module project, its value should point to a project.basedir of a > root module > Example: > multi-module // located at /home/me/sources > +- module-a > +- module B > Sample multi-module/pom.xml: > {{<project>}} > {{ <parent>}} > {{ <groupId>com.acme</groupId>}} > {{ <artifactId>corp-parent</artifactId>}} > {{ <version>1.0.0-RELEASE</version>}} > {{ </parent>}} > {{ <groupId>com.acme</groupId>}} > {{ <artifactId>multi-module</artifactId>}} > {{ <version>0.5.2-SNAPSHOT</version>}} > {{ <modules>}} > {{ <module>module-a</module>}} > {{ <module>module-b</module>}} > {{ </modules>}} > {{</project>}} > The property requested should return /home/me/sources/multi-module, > regardless of whether it's referenced in any of the child modules (module-a, > module-b) or in multi-module. > Note that multi-module itself has parent (e.g. installed in a local > repository), so the new property should be smart enough to detect it and > still point to /home/me/sources/multi-module instead of the local repository > where the corp-parent is installed. > The use-case for such a property could be to have a directory for combined > report of static analysis tools. Typical example - jacoco combined coverage > reports. -- This message was sent by Atlassian Jira (v8.20.10#820010)