[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #254: [MENFORCER-466] Apply the all levels scope and optional selectors on RequireUpperBoundDeps

[via GitHub]

slawekjaranowski commented on code in PR #254:
URL: https://github.com/apache/maven-enforcer/pull/254#discussion_r1140614877


##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/DependencyConvergence.java:
##########
@@ -49,8 +49,6 @@ public final class DependencyConvergence extends 
AbstractStandardEnforcerRule {
 
     private List<String> excludes;
 
-    private List<String> scopes = Arrays.asList(Artifact.SCOPE_COMPILE, 
Artifact.SCOPE_RUNTIME, Artifact.SCOPE_SYSTEM);

Review Comment:
   This was a new parameter according to: MENFORCER-470
   
   But ok - I will restore it as `exludesScopes`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org