michael-o commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r1133232968


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##########
@@ -67,9 +75,16 @@
  * @author <a href="mailto:br...@apache.org";>Brett Porter</a>
  * @author Robert Scholte
  */
+@Component( role = ReleasePhase.class, hint = "map-release-versions" )
 public abstract class AbstractMapVersionsPhase

Review Comment:
   I know the reason and I believe this is wrong. We have changed to 
constructor injection. Thus the implementing classes have `@Inject` annotated 
constructors and there your instance should be provided. @cstamas 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to