[
https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697579#comment-17697579
]
ASF GitHub Bot commented on MNG-7720:
-------------------------------------
cstamas commented on code in PR #1040:
URL: https://github.com/apache/maven/pull/1040#discussion_r1128379457
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java:
##########
@@ -90,7 +90,11 @@ public LifecycleDependencyResolver(
public static List<MavenProject> getProjects(MavenProject project,
MavenSession session, boolean aggregator) {
if (aggregator && project.getCollectedProjects() != null) {
Review Comment:
It seems this is really "just implementation details" (that when top level
project collectedProjects is not null, then there is no project instance that
would have collectedProjects null). So added nullcheck just to be on safe side.
> [REGRESSION] Build order is incorrect and does not respect Reactor Build Order
> ------------------------------------------------------------------------------
>
> Key: MNG-7720
> URL: https://issues.apache.org/jira/browse/MNG-7720
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
> Affects Versions: 3.9.0
> Reporter: Joe Littlejohn
> Assignee: Tamas Cservenak
> Priority: Blocker
> Fix For: 4.0.0, 4.0.0-alpha-5, 3.8.8, 3.9.1
>
>
> I have a multi-module project. When using Maven 3.9.0, my project fails to
> build. The problem appears to be that the Reactor Build Order is not
> respected when the build actually runs.
> When the build runs, I see this output:
> {code:java}
> [INFO] Reactor Build Order:
> 15[INFO]
> 16[INFO] jsonschema2pojo
> [pom]
> 17[INFO] jsonschema2pojo-core
> [jar]
> 18[INFO] jsonschema2pojo-ant
> [jar]
> 19[INFO] jsonschema2pojo-cli
> [jar]
> 20[INFO] jsonschema2pojo-gradle-plugin
> [jar]
> 21[INFO] jsonschema2pojo-maven-plugin
> [maven-plugin]
> 22[INFO] jsonschema2pojo-integration-tests
> [jar] {code}
> However Maven first builds jsonschema2pojo, and next tries to build
> jsonschema2pojo-ant instead of jsonschema2pojo-core. The build fails because
> jsonschema2pojo-core is not found.
> There is a full log available here:
> https://github.com/joelittlejohn/jsonschema2pojo/actions/runs/4332878826/jobs/7565796916
> Workaround: Downgrade to Maven 3.8.7 and the problem goes away.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
