[
https://issues.apache.org/jira/browse/MNG-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695623#comment-17695623
]
ASF GitHub Bot commented on MNG-6889:
-------------------------------------
michael-o commented on code in PR #1026:
URL: https://github.com/apache/maven/pull/1026#discussion_r1122851290
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager(
MavenExecutionRequest request, Default
session.setLocalRepositoryManager(
simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using
legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due
fact that with this option" );
Review Comment:
Sentence here, start upper case.
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager(
MavenExecutionRequest request, Default
session.setLocalRepositoryManager(
simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using
legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due
fact that with this option" );
Review Comment:
The warning is a duplicate.
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager(
MavenExecutionRequest request, Default
session.setLocalRepositoryManager(
simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using
legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due
fact that with this option" );
+ logger.warn( "Maven cannot provide the latest local repository
features, it is being " );
+ logger.warn( "DEPRECATED. Moreover, this option is being
DROPPED starting with Maven 3.9.1, and use" );
Review Comment:
Move "DEPRECATED" up a line
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager(
MavenExecutionRequest request, Default
session.setLocalRepositoryManager(
simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using
legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due
fact that with this option" );
+ logger.warn( "Maven cannot provide the latest local repository
features, it is being " );
Review Comment:
Trailing space
> Mark command line option --legacy-local-repository as deprecated
> ----------------------------------------------------------------
>
> Key: MNG-6889
> URL: https://issues.apache.org/jira/browse/MNG-6889
> Project: Maven
> Issue Type: Task
> Components: Command Line
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 3.8.8
>
>
> We should at least mark this option as deprecated or even better remove this
> option but this would be inconsistent to remove something which has not been
> marked deprecated before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
