mthmulders opened a new pull request, #995:
URL: https://github.com/apache/maven/pull/995
This pull request adds a few basic checks that users can run to see if
they've installed Maven correctly. This includes:
1. A check if the local Maven repository is usable.
2. A check if Maven can connect to remote repositories configured in
**settings.xml**.
3. A check if Maven can resolve a pre-existing artifact (to be precise,
`org.apache.maven:apache-maven:3.8.6`).
These checks honour **settings.xml** profile activation through
`<activeProfiles>`. The artifact resolution check honours any configured
mirrors.
The connection check is quite rudimentary, and only functions at the HTTP
connection level. Since there is no guarantee that a repository will contain a
particular artifact, there's not much more we can do.
The artifact resolution check is a bit more thorough: it checks if there is
_any_ way in which Maven can resolve itself. It does so by temporarily using a
"dummy" local repository. This is necessary to prevent a "false positive",
where the artifact may have existed before.
We have not added unit tests or integration tests (yet). At some level, they
may be useful, but we expect a full integration test to be a significant amount
of work that would not provide a lot of value. We're curious to hear your
opinions about that trade-off.
---
Following this checklist to help us incorporate your contribution quickly
and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
--> [MNG-6869](https://issues.apache.org/jira/browse/MNG-6869)
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
