[
https://issues.apache.org/jira/browse/DOXIATOOLS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684730#comment-17684730
]
ASF GitHub Bot commented on DOXIATOOLS-75:
------------------------------------------
kwin commented on code in PR #38:
URL:
https://github.com/apache/maven-doxia-converter/pull/38#discussion_r1097497739
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -357,23 +458,19 @@ private void parse( File inputFile, String inputEncoding,
String inputFormat, Ou
}
File outputFile;
- if ( output.getFile().isDirectory() )
+ if ( outputDirectoryOrFile.isDirectory()
+ || !SelectorUtils.match( "**.*", output.getFile().getName() )
Review Comment:
Rather `*.*` because it only matches on the file name (not the full path),
however I haven't modified the globbing either. Let us not put too much into
this PR.
> Replace extensions and keep subdirectories when converting directories
> ----------------------------------------------------------------------
>
> Key: DOXIATOOLS-75
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-75
> Project: Maven Doxia Tools
> Issue Type: Bug
> Components: Doxia Converter
> Affects Versions: doxia-converter-1.3
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: doxia-converter-1.4
>
>
> When a full directory is given to the CLI argument {{in}} the output files
> don't replace the extension of the input files but just append the one of the
> target format. In addition the subfolder structure is lost. Also only files
> having an extension which is equal to the given {{-from}} value are found.
> For example when using
> {code:java}
> java -jar doxia-converter-1.3-jar-with-dependencies.jar -in
> maven-site/content/apt -from apt -out maven-site/content/markdown -to markdown
> {code}
> the following files are created:
> {{maven-site/content/markdown/central-index.apt.markdown}} (from source file
> [https://github.com/apache/maven-site/blob/master/content/apt/repository/central-index.apt]),
> while the expected target file name would rather be
> {{maven-site/content/markdown/repository/central-index.markdown}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
