kwin commented on code in PR #38: URL: https://github.com/apache/maven-doxia-converter/pull/38#discussion_r1097497739
########## src/main/java/org/apache/maven/doxia/DefaultConverter.java: ########## @@ -357,23 +458,19 @@ private void parse( File inputFile, String inputEncoding, String inputFormat, Ou } File outputFile; - if ( output.getFile().isDirectory() ) + if ( outputDirectoryOrFile.isDirectory() + || !SelectorUtils.match( "**.*", output.getFile().getName() ) Review Comment: Rather `*.*` because it only matches on the file name (not the full path), however I haven't modified the globbing either. Let us not put too much into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org