[
https://issues.apache.org/jira/browse/DOXIA-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681792#comment-17681792
]
ASF GitHub Bot commented on DOXIA-690:
--------------------------------------
kwin commented on code in PR #141:
URL: https://github.com/apache/maven-doxia/pull/141#discussion_r1090038860
##########
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java:
##########
@@ -76,19 +83,23 @@ public class MarkdownParser extends AbstractTextParser
implements TextMarkup {
* In order to ensure that we have minimal risk of false positives when
slurping metadata sections, the
* first key in the metadata section must be one of these standard keys or
else the entire metadata section is
* ignored.
+ * @see <a
href="https://fletcher.github.io/MultiMarkdown-5/metadata.html";>Multimarkdown
Metadata</a>
Review Comment:
No, but Doxia Markdown supports it (since the beginning I guess). Compare
also with https://github.com/vsch/flexmark-java/issues/550. I haven't added,
only refactored and extended for multiline support and added the underlying
spec.
> Markdown Parser: Multiline metadata incorrectly rendered
> --------------------------------------------------------
>
> Key: DOXIA-690
> URL: https://issues.apache.org/jira/browse/DOXIA-690
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Markdown uses the following metadata format in its sink:
> [http://fletcher.github.io/MultiMarkdown-5/metadata.html].
> In case a metadata key has multiple values on multiple lines it is emitted as
> following from the {{MarkdownSink}}:
> {code:java}
> title: Guide to creating a site
> author: Brett Porter
> Jason van Zyl
> date: 2015-07-18 {code}
> That leads to incorrect XHTML output as the second line for {{author}} is not
> detected correctly and instead of being emitted as metadata is emitted as
> regular paragraph in the HTML body. This is due to
> https://github.com/apache/maven-doxia/blob/7509feb03af4d4fb7d48b4f9ef38ff5c1a17a149/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownParser.java#L110
> only detecting single line metadata values.
> Although this might be a glitch of the underlying Markdown Parser
> implementation the metadata format explicitly recommends:
> {quote}
> To keep multiline metadata values from being confused with additional
> metadata, I recommend indenting each new line of metadata. If your metadata
> value includes a colon, it must be indented to keep it from being treated as
> a new key-value pair
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
