[GitHub] [maven-resolver] cstamas commented on pull request #236: handle thread interrupts on transitive dependencies parsing (infinite loop)

[via GitHub]

cstamas commented on PR #236:
URL: https://github.com/apache/maven-resolver/pull/236#issuecomment-1406708746

   The snippet changes I have locally: switch to BF collector and using 
musquette artifact:
   
   ```diff
   diff --git 
a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/GetDependencyTree.java
 
b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/GetDependencyTree.java
   index 78af7839..050c96b8 100644
   --- 
a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/GetDependencyTree.java
   +++ 
b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/GetDependencyTree.java
   @@ -21,6 +21,7 @@ package org.apache.maven.resolver.examples;
    
    import org.apache.maven.resolver.examples.util.Booter;
    import org.apache.maven.resolver.examples.util.ConsoleDependencyGraphDumper;
   +import org.eclipse.aether.DefaultRepositorySystemSession;
    import org.eclipse.aether.RepositorySystem;
    import org.eclipse.aether.RepositorySystemSession;
    import org.eclipse.aether.artifact.Artifact;
   @@ -28,6 +29,7 @@ import org.eclipse.aether.artifact.DefaultArtifact;
    import org.eclipse.aether.collection.CollectRequest;
    import org.eclipse.aether.collection.CollectResult;
    import org.eclipse.aether.graph.Dependency;
   +import org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector;
    
    /**
     * Collects the transitive dependencies of an artifact.
   @@ -48,9 +50,10 @@ public class GetDependencyTree
    
            RepositorySystem system = Booter.newRepositorySystem( 
Booter.selectFactory( args ) );
    
   -        RepositorySystemSession session = 
Booter.newRepositorySystemSession( system );
   +        DefaultRepositorySystemSession session = 
Booter.newRepositorySystemSession( system );
   +        session.setConfigProperty("aether.dependencyCollector.impl", 
BfDependencyCollector.NAME );
    
   -        Artifact artifact = new DefaultArtifact( 
"org.apache.maven:maven-resolver-provider:3.6.1" );
   +        Artifact artifact = new DefaultArtifact( 
"org.webjars.npm:musquette:1.1.1" );
    
            CollectRequest collectRequest = new CollectRequest();
            collectRequest.setRoot( new Dependency( artifact, "" ) );
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org