[
https://issues.apache.org/jira/browse/MWRAPPER-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680993#comment-17680993
]
ASF GitHub Bot commented on MWRAPPER-75:
----------------------------------------
jorsol commented on PR #58:
URL: https://github.com/apache/maven-wrapper/pull/58#issuecomment-1405007910
Ohhh, I missed that comment, anyway I genuinely think that this should be
checked even at the expense of calculating the checksum on every Maven execute.
@slawekjaranowski maybe this need to be revisited since the recent Gradle
Wrapper attack (https://blog.gradle.org/wrapper-attack-report) WDYT?
> Allow for sha256 checksum verification of downloaded artifacts.
> ---------------------------------------------------------------
>
> Key: MWRAPPER-75
> URL: https://issues.apache.org/jira/browse/MWRAPPER-75
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Jar, Maven Wrapper Plugin, Maven Wrapper
> Scripts
> Reporter: Rafael Winterhalter
> Assignee: Slawomir Jaranowski
> Priority: Normal
> Fix For: 3.2.0
>
>
> Maven Wrapper is downloading binary artifacts that are later executed. To
> prevent from an attack where a vulnerable repository could distribute
> malicious Maven (wrapper) artifacts, the downloaded artifacts should be
> verified against a secure checksum. If the expected checksum does not match,
> execution could be aborted before the potentially compromised artifact is
> executed.
> In my PR, i chose SHA-256 as it is cheaper to compute than SHA-512 but still
> impossible to replicate with a corrupted binary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
