ascopes commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r1083433677
##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -194,7 +194,9 @@ else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
while IFS="=" read -r key value; do
- case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+ # Remove '\r' from value to allow usage on windows as IFS does not
consider '\r' as a separator ( considers space, tab, new line ('\n'), and
custom '=' )
+ safeValue=$(echo "$value" | sed 's/\r$//')
Review Comment:
using
```
`command`
```
may be favourable compared to
```
$(...)
```
...as some sources specify that $() doesn't appear to be supported by csh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
