cstamas commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1396567377

   After reconsidering this change, I am -1 on it (now or 2.x), reasons:
   * I see no point of adding new methods to resolver interface that resolver 
itself is NOT going to use
   * obviously, these methods are needed to some "integrator" of resolver, but 
as can be seen on example of Maven (as one of integrator), one can introduces 
specific reader (in maven it is MavenWorkspaceReader) and decorate it by adding 
specific methods to it
   * also,by adding methods here  we would force any other integrator to 
implement them even if they would not need it (as resolver itself is not using 
these either).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to