[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677535#comment-17677535 ]
ASF GitHub Bot commented on MNG-7629: ------------------------------------- gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1071616763 ########## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ########## @@ -324,4 +300,113 @@ private static boolean isTestArtifact(Artifact artifact) { return ("test-jar".equals(artifact.getProperty("type", ""))) || ("jar".equals(artifact.getExtension()) && "tests".equals(artifact.getClassifier())); } + + private File find(Artifact artifact) { + Path target = getArtifactPath(artifact); + return Files.isRegularFile(target) ? target.toFile() : null; + } + + public void processProject(MavenProject project) { + List<Artifact> artifacts = new ArrayList<>(); + + artifacts.add(RepositoryUtils.toArtifact(new ProjectArtifact(project))); + if (!"pom".equals(project.getPackaging())) { + org.apache.maven.artifact.Artifact mavenMainArtifact = project.getArtifact(); + artifacts.add(RepositoryUtils.toArtifact(mavenMainArtifact)); + } + for (org.apache.maven.artifact.Artifact attached : project.getAttachedArtifacts()) { + artifacts.add(RepositoryUtils.toArtifact(attached)); + } + + for (Artifact artifact : artifacts) { + if (artifact.getFile() != null && artifact.getFile().isFile()) { + Path target = getArtifactPath(artifact); + try { + LOGGER.debug("Copying {} to project local repository", artifact); + Files.createDirectories(target.getParent()); + Files.copy( + artifact.getFile().toPath(), + target, + StandardCopyOption.REPLACE_EXISTING, + StandardCopyOption.COPY_ATTRIBUTES); + } catch (IOException e) { + LOGGER.warn("Error while copying artifact to project local repository", e); + } + } + } + } + + private Path getArtifactPath(Artifact artifact) { + String groupId = artifact.getGroupId(); + String artifactId = artifact.getArtifactId(); + String version = artifact.getBaseVersion(); + String classifier = artifact.getClassifier(); + String extension = artifact.getExtension(); + Path repo = getProjectLocalRepo(); + return repo.resolve(groupId) + .resolve(artifactId) + .resolve(artifactId + + "-" + version + + (classifier != null && !classifier.isEmpty() ? "-" + classifier : "") + + (extension != null && !extension.isEmpty() ? "." + extension : "")); Review Comment: You're right, it cannot. > Improve resolution of modules within a multi-module build > --------------------------------------------------------- > > Key: MNG-7629 > URL: https://issues.apache.org/jira/browse/MNG-7629 > Project: Maven > Issue Type: Task > Reporter: Guillaume Nodet > Assignee: Guillaume Nodet > Priority: Major > Fix For: 4.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)