ppalaga commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1067958247
########## dist/src/main/distro/bin/mvnd.cmd: ########## @@ -25,6 +25,11 @@ @REM MAVEN_BATCH_PAUSE (Optional) set to 'on' to wait for a key stroke before ending. @REM MAVEN_OPTS (Optional) Java runtime options used when Maven is executed. @REM MAVEN_SKIP_RC (Optional) Flag to disable loading of mavenrc files. +@REM MVND_CLIENT (Optional) Control how to select mvnd client to communicate with the daemon: +@REM 'auto' (default) - prefer the native client mvnd if it works; otherwise use +@REM the pure Java client. +@REM 'native' - use the native client mvnd.exe Review Comment: This is windows, so we can use `mvnd.exe` every where, no? `if it works` sounds a bit unspecific to me. Could we please somehow concisely describe what the script actually does? ```suggestion @REM MVND_CLIENT (Optional) Control how to select mvnd client to communicate with the daemon: @REM 'auto' (default) - prefer the native client mvnd.exe if it suits the current OS and processor architecture; otherwise use @REM the pure Java client. @REM 'native' - use the native client mvnd.exe ``` ########## dist/src/main/distro/bin/mvnd.sh: ########## @@ -25,6 +25,11 @@ # JAVA_HOME Must point at your Java Development Kit installation. # MAVEN_OPTS (Optional) Java runtime options used when Maven is executed. # MAVEN_SKIP_RC (Optional) Flag to disable loading of mavenrc files. +# MVND_CLIENT (Optional) Control how to select mvnd client to communicate with the daemon: +# 'auto' (default) - prefer the native client mvnd if it works; otherwise use +# the pure Java client. +# 'native' - use the native client mvnd.exe Review Comment: Similar like above: ```suggestion # MVND_CLIENT (Optional) Control how to select mvnd client to communicate with the daemon: # 'auto' (default) - prefer the native client mvnd if it suits the current OS and processor architecture; otherwise use # the pure Java client. # 'native' - use the native client mvnd ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
