[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655481#comment-17655481
]
ASF GitHub Bot commented on MWRAPPER-88:
----------------------------------------
bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063537820
##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -39,7 +39,7 @@ jobs:
- name: check
run: |
echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >>
$GITHUB_PATH
- readarray -t SCRIPT_FILES < <(grep -ErIl
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+ readarray -t SCRIPT_FILES < <(grep -ErIl -e
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
Review Comment:
Can do. But then, we should only write POSIX scripts so it runs everywhere.
This would only be needed for shell specific scripts. I'd consider it optional,
but will add it later.
Thanks for the finding.
> mvnw is not POSIX compatible
> ----------------------------
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.1
> Reporter: Benjamin Marwell
> Assignee: Benjamin Marwell
> Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
