[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity

[GitBox]

bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063537820


##########
.github/workflows/shellcheck-posix.yml:
##########
@@ -39,7 +39,7 @@ jobs:
       - name: check
         run: |
           echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >> 
$GITHUB_PATH
-          readarray -t SCRIPT_FILES < <(grep -ErIl 
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' 
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+          readarray -t SCRIPT_FILES < <(grep -ErIl -e 
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e 
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh' 
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")

Review Comment:
   Can do. But then, we should only write POSIX scripts so it runs everywhere. 
This would only be needed for shell specific scripts. I'd consider it optional, 
but will add it later.
   
   Thanks for the finding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org