laeubi commented on PR #948: URL: https://github.com/apache/maven/pull/948#issuecomment-1371290310
> Um, this looks wrong to me.... I guess this is to have injected some components that are session scoped? Yes as described in the JIRA ticket > But why not use `Provider<X>` for components that are session scoped instead, as that will throw anyway if invoked out of session.... Mostly because consumers should not need to know how the component is implemented, beside this I never got `Provider<X>` working (Maven 3.8.x) the build always complains something can not be injected. But maybe DefaultMavenComponent should all be `Provider<X>` ones so this do not conflict with implementation details? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
