[
https://issues.apache.org/jira/browse/MNG-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654328#comment-17654328
]
ASF GitHub Bot commented on MNG-7596:
-------------------------------------
hboutemy commented on code in PR #866:
URL: https://github.com/apache/maven/pull/866#discussion_r1061205771
##########
maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java:
##########
@@ -180,8 +181,6 @@ public void writeToSerializer(String namespace,
XmlSerializer serializer) throws
* </ol></li>
* <li> If mergeSelf == true
* <ol type="A">
- * <li> if the dominant root node's value is empty, set it to the
recessive root node's value</li>
- * <li> For each attribute in the recessive root node which is not set
in the dominant root node, set it.</li>
Review Comment:
I don't know if that can help, but big efforts were made in the past on
maven-shared-utils reimplementation, with its test suite:
https://github.com/apache/maven-shared-utils/blob/master/src/test/java/org/apache/maven/shared/utils/xml/pull/Xpp3DomTest.java
perhaps that can be reused
> Upgrade to plexus-utils 3.5.0
> -----------------------------
>
> Key: MNG-7596
> URL: https://issues.apache.org/jira/browse/MNG-7596
> Project: Maven
> Issue Type: Dependency upgrade
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-3, 4.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
