[
https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654065#comment-17654065
]
ASF GitHub Bot commented on MNG-7652:
-------------------------------------
hboutemy commented on code in PR #944:
URL: https://github.com/apache/maven/pull/944#discussion_r1060691858
##########
api/maven-api-model/pom.xml:
##########
@@ -63,26 +63,26 @@ under the License.
</executions>
</plugin>
<plugin>
- <groupId>org.apache.maven</groupId>
- <artifactId>modello-plugin-velocity</artifactId>
- <configuration>
- <version>4.2.0</version>
- <models>
- <model>src/main/mdo/maven.mdo</model>
- </models>
- <templates>
- <template>src/main/mdo/model.vm</template>
- </templates>
- <params>
- <param>packageModelV4=org.apache.maven.api.model</param>
- </params>
- </configuration>
+ <groupId>org.codehaus.modello</groupId>
+ <artifactId>modello-maven-plugin</artifactId>
<executions>
<execution>
- <id>modello</id>
+ <id>velocity</id>
<goals>
<goal>velocity</goal>
</goals>
+ <configuration>
+ <version>4.2.0</version>
+ <models>
+ <model>src/main/mdo/maven.mdo</model>
+ </models>
+ <templates>
+ <template>src/main/mdo/model.vm</template>
+ </templates>
Review Comment:
1. it has been our convention for ever
https://github.com/apache/maven/tree/maven-3.9.x/maven-model/src/main/mdo
2. it's really main code that it generated, then storing in `src/main` makes
sense
3. IIRC, in some cases, we generated test code from models, storing model in
`src/test/mdo`: unusual, but real
> switch to Modello Velocity Maven plugin
> ---------------------------------------
>
> Key: MNG-7652
> URL: https://issues.apache.org/jira/browse/MNG-7652
> Project: Maven
> Issue Type: Sub-task
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
>
> a Modello Velocity generator has been added to Maven core, but its target
> localtion is Modello itself: PR openend
> https://github.com/codehaus-plexus/modello/pull/269
> once Modello 2.1.0 is released, Maven core needs to delete internal one and
> switch
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
