andpab commented on code in PR #554:
URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059654222


##########
surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java:
##########
@@ -180,6 +180,8 @@ public synchronized File createTempFile( String prefix, 
String suffix )
                     throw new UncheckedIOException( new IOException(
                                     "Unable to create temporary directory " + 
tempDir.getAbsolutePath() ) );
                 }
+                // try to make temp file directory writable for all
+                tempDir.setWritable( true, false );

Review Comment:
   That would bloat the system temp directory again, so it would run counter to 
the motivation for the original change as described in SUREFIRE-2086.
   
   As @sman-81 said: The aim of the original PR was to stop Surefire from 
bloating the system temp directory by instead having it create the new 
directory in a fixed subdirectory of the system temp directory, not the system 
temp directory itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to