[ 
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651642#comment-17651642
 ] 

ASF GitHub Bot commented on MNG-7559:
-------------------------------------

sultan commented on PR #929:
URL: https://github.com/apache/maven/pull/929#issuecomment-1363909838

   > * I don't see how a build qualifier makes sense after post-release where a 
release is supposed to be immutable and identical according to SemVer
   
   yeah i forgot that, sorry.
   1.2.3 and 1.2.3+1 should be iso-feature and iso-fixes.
   
   the SemVer way to achieve this would be on the artifact id:
   * :commons-io:2.12.0
   * :commons-io-2.12.0-company:1.0.0 (ugly? yes...)
   
   yes the very adding of 'company' as a qualifier is ambiguous regarding to 
features and versions ordering 




> ComparableVersion vs versions with custom qualifiers
> ----------------------------------------------------
>
>                 Key: MNG-7559
>                 URL: https://issues.apache.org/jira/browse/MNG-7559
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.8.3
>            Reporter: Andrzej Jarmoniuk
>            Priority: Major
>             Fix For: 4.x / Backlog
>
>         Attachments: image-2022-10-22-18-22-11-591.png
>
>
> Since I know that ComparableVersion was brought to Maven from 
> versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should 
> be treated as less major than the same versions without the qualifier. 
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*", 
> "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
>     @Test
>     public void testComparableVersionWithCustomQualifier()
>     {
>         assertThat( new ComparableVersion( "2.3" ).compareTo( new 
> ComparableVersion( "2.3-pfd" ) ),
>                 greaterThan( 0 ) );
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to