sultan commented on PR #929: URL: https://github.com/apache/maven/pull/929#issuecomment-1363828385
> Bah, I am really about to puke. > > So much completely for something quite obvious, I guess. > > Looking at `"<<<.qualifier>>>" < "<<<-qualifier>>>" < "<<<-number>>>" < "<<<.number>>>"` it does not make sense, why the dot before a hyphen. If now the equalty applies to qualifiers, why not to nubers as well? The problem ist how to diffentiate between 2.3.4 where 4 is a actually a numeric qualfier? the parser was and is treating numbers and string differently (else/if). the previous parser * 2.3.4 parses to [ 2, 3, 4 ] * 2.3-4 parse to [ 2, 3, [4] ] * 2.3-RC4 parses to [ 2, 3, [ RC, [4] ] ] * 2.3.RC4 used to parse to [ 2, 3, RC, [4] ] i can see a benefit of change with .RC4 = -RC4 and .RC1 < -RC2 but i cannot yet see a benefit of change for numbers, as you may want to keep 1.0.0-2 = 1-2 = 1.0-2 treat - as dot for numbers will lead to bad surprises. we might not want 1.0.0-2 = 1.0.0.2 < 1.0-2 = 1.0.2 < 1-2 = 1.2 we should discourage the use of numeric qualifiers -1, -2 -N in the docs i dont see what the projects maintainers would want for these numbers to mean and how they would compare with strings (< or >?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
