[ 
https://issues.apache.org/jira/browse/MNG-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649048#comment-17649048
 ] 

Herve Boutemy edited comment on MNG-7352 at 12/23/22 12:40 AM:
---------------------------------------------------------------

Look at 
[61f1d01ba86e0765e0a78eb0b18571ee503055f6|https://github.com/apache/maven/commit/61f1d01ba86e0765e0a78eb0b18571ee503055f6].
 [~hboutemy], well this class was public, you assumed it should be package 
private, though the deprecated one does not provide a public successor. I am 
included to make this public again. WDYT?


was (Author: michael-o):
Look at 61f1d01ba86e0765e0a78eb0b18571ee503055f6. [~hboutemy], well this class 
was public, you assumed it should be package private, though the deprecated one 
does not provide a public successor. I am included to make this public again. 
WDYT?

> org.apache.maven.toolchain.java.JavaToolchainImpl should be public
> ------------------------------------------------------------------
>
>                 Key: MNG-7352
>                 URL: https://issues.apache.org/jira/browse/MNG-7352
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.8.4
>            Reporter: Michael Keppler
>            Assignee: Michael Osipov
>            Priority: Trivial
>             Fix For: 3.8.x-candidate, 3.9.0-candidate, 4.0.x-candidate, 
> waiting-for-feedback
>
>
> org.apache.maven.toolchain.java.JavaToolchainImpl has been created as 
> replacement for the now deprecated 
> org.apache.maven.toolchain.java.DefaultJavaToolChain.
> However, the deprecated class was public, the new one isn't. That makes it 
> impossible to follow the deprecation note to use the new class (outside of 
> Maven core). I'm trying to fix this deprecation in Maven Tycho.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to