slawekjaranowski commented on code in PR #874:
URL: https://github.com/apache/maven/pull/874#discussion_r1048805974
##########
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##########
@@ -51,9 +37,9 @@ private SettingsUtils()
* @param recessive
* @param recessiveSourceLevel
*/
- public static Settings merge( Settings dominant, Settings recessive,
String recessiveSourceLevel )
+ public static void merge( Settings dominant, Settings recessive, String
recessiveSourceLevel )
{
- return new MavenSettingsMerger().merge( dominant, recessive,
recessiveSourceLevel );
+ SettingsUtilsV4.merge( dominant.getDelegate(),
recessive.getDelegate(), recessiveSourceLevel );
Review Comment:
`dominant` and `recessive` can be null in v3.
caller expect that `dominant` will have a result of merge , so we need
```
dominant.delegate = SettingsUtilsV4.merge( ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
