[ 
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645854#comment-17645854
 ] 

ASF GitHub Bot commented on MNG-7622:
-------------------------------------

michael-o commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045299177


##########
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##########
@@ -144,4 +152,17 @@ private static BiConsumer<Path, Path> 
transformer(RepositorySystemSession sessio
             };
         }
     }
+
+    /**
+     * The actual transformation: visible for testing.
+     */
+    static InputStream transform(Path pomFile, TransformerContext context) 
throws IOException, XmlPullParserException {
+        XmlStreamReader reader = 
ReaderFactory.newXmlReader(Files.newInputStream(pomFile));
+        XmlPullParser parser = new MXParser( 
EntityReplacementMap.defaultEntityReplacementMap);

Review Comment:
   whitespace





> Reimplement Consumer POM feature
> --------------------------------
>
>                 Key: MNG-7622
>                 URL: https://issues.apache.org/jira/browse/MNG-7622
>             Project: Maven
>          Issue Type: Task
>          Components: build/consumer
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it 
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p 
> broken.
> Reimplement consumer POM feature that:
>  * does not use FileTransformer API
>  * allows use cases like m-gpg-p



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to