cstamas commented on code in PR #226:
URL: https://github.com/apache/maven-resolver/pull/226#discussion_r1041882368
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:
##########
@@ -263,42 +270,73 @@ private DeployResult deploy( SyncContext syncContext,
RepositorySystemSession se
processedMetadata.put( metadata, null );
}
- for ( ListIterator<Artifact> iterator = artifacts.listIterator();
iterator.hasNext(); )
+ MultiProcessor<TransformedArtifact> multiProcessor = new
MultiProcessor<>( TransformedArtifact::close );
+ try
{
- Artifact artifact = iterator.next();
-
- for ( MetadataGenerator generator : generators )
+ for ( ListIterator<Artifact> iterator =
artifacts.listIterator(); iterator.hasNext(); )
{
- artifact = generator.transformArtifact( artifact );
- }
-
- iterator.set( artifact );
+ Artifact artifact = iterator.next();
- Collection<FileTransformer> fileTransformers =
- fileTransformerManager.getTransformersForArtifact(
artifact );
- if ( !fileTransformers.isEmpty() )
- {
- for ( FileTransformer fileTransformer : fileTransformers )
+ for ( MetadataGenerator generator : generators )
{
- Artifact targetArtifact =
fileTransformer.transformArtifact( artifact );
+ artifact = generator.transformArtifact( artifact );
+ }
- ArtifactUpload upload = new ArtifactUpload(
targetArtifact, artifact.getFile(),
- fileTransformer );
- upload.setTrace( trace );
- upload.setListener( new ArtifactUploadListener(
catapult, upload ) );
- artifactUploads.add( upload );
+ iterator.set( artifact );
+
+ Collection<FileTransformer> fileTransformers =
+ fileTransformerManager.getTransformersForArtifact(
artifact );
+ if ( !fileTransformers.isEmpty() )
Review Comment:
Yes, as explained in PR comment and also package-info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
