[ 
https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642507#comment-17642507
 ] 

ASF GitHub Bot commented on MNG-7614:
-------------------------------------

kwin commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038145135


##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession 
newRepositorySession(MavenExecutionRequest
 
                 XmlPlexusConfiguration config = new 
XmlPlexusConfiguration(dom);
                 configProps.put("aether.connector.wagon.config." + 
server.getId(), config);
+
+                // Translate to proper resolver configuration properties as 
well (as Plexus XML above is Wagon specific
+                // only)
+                // but support only configuration/httpConfiguration/all, not 
the per-method nonsense

Review Comment:
   `not the per-method nonsense` :-) maybe just mention that only method `all` 
is supported.





> Maven should translate transport configuration fully to resolver transports.
> ----------------------------------------------------------------------------
>
>                 Key: MNG-7614
>                 URL: https://issues.apache.org/jira/browse/MNG-7614
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 3.9.0
>
>
> Maven should properly translate transport configuration, instead to assume 
> Wagon.
> Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this 
> needs to be backported, as it got native transporter as part of MNG-7454 but 
> confguration translation still needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to