[GitHub] [maven] gnodet commented on a diff in pull request #816: Small optimisations and cleanup

[GitBox]

gnodet commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038039145

##########
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##########
@@ -23,17 +23,19 @@
 import org.codehaus.plexus.interpolation.AbstractValueSource;
 
 class BuildTimestampValueSource extends AbstractValueSource {
-    private final MavenBuildTimestamp mavenBuildTimestamp;
+    private final Date startTime;
+    private final Map<String, String> properties;
 
     BuildTimestampValueSource(Date startTime, Map<String, String> properties) {
         super(false);
-        this.mavenBuildTimestamp = new MavenBuildTimestamp(startTime, 
properties);
+        this.startTime = startTime;
+        this.properties = properties;

Review Comment:
   We could, but the only usage is when passed to the `MavenBuildTimestamp` 
which does support `null`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org