[
https://issues.apache.org/jira/browse/MNGSITE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641552#comment-17641552
]
ASF GitHub Bot commented on MNGSITE-501:
----------------------------------------
gnodet commented on code in PR #346:
URL: https://github.com/apache/maven-site/pull/346#discussion_r1036426893
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P
profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an
<<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
Review Comment:
`prefix` seems an important word to describe what happens here. Is that a
willingful removal ?
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P
profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an
<<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
+ the presence of a system property or the value of a system property. Here
are some examples.
Review Comment:
`the presence or value of a system property.`
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P
profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an
<<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
+ the presence of a system property or the value of a system property. Here
are some examples.
The following configuration will trigger the profile when the JDK's
- version starts with "1.4" (eg. "1.4.0_08", "1.4.2_07", "1.4"):
+ version <starts with> "1.4" (eg. "1.4.0_08", "1.4.2_07", "1.4"),
particularly it <won't be active>
Review Comment:
`particularly` -> `in particular`
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P
profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an
<<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
Review Comment:
`JDK version matching, operating system matching,`
> Clarify JDK activation element
> ------------------------------
>
> Key: MNGSITE-501
> URL: https://issues.apache.org/jira/browse/MNGSITE-501
> Project: Maven Project Web Site
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Both in [https://maven.apache.org/pom.html#Activation] and
> [https://maven.apache.org/guides/introduction/introduction-to-profiles.html#details-on-profile-activation]
> the {{jdk}} element needs clarification that not all values are interpreted
> as ranges (in contrast to what the referenced version range specification
> from enforcer maven plugin in
> [https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] says).
> Actually there are three different kind of values supported:
> # Version ranges (if the value starts with either "[" or "(")
> # A negated prefix (if the value starts with "!")
> # A (non-negated) prefix for all other cases
> This can be seen in
> [https://github.com/apache/maven/blob/001eef8452b38110a2557446aa81b8fb1ff35f92/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java#L69]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
