[
https://issues.apache.org/jira/browse/MPLUGIN-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641332#comment-17641332
]
ASF GitHub Bot commented on MPLUGIN-443:
----------------------------------------
michael-o commented on code in PR #177:
URL:
https://github.com/apache/maven-plugin-tools/pull/177#discussion_r1036020183
##########
maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocReferenceTest.java:
##########
@@ -45,6 +45,8 @@ void testParse()
JavadocReference.parse(
"package.Class#member(ArgType1,ArgType2) label" ) );
assertEquals( new JavadocReference( Optional.of("my.module"),
Optional.of( "package.Class" ), Optional.of( "member(ArgType1,ArgType2)" ),
Optional.of("label") ),
JavadocReference.parse(
"my.module/package.Class#member(ArgType1,ArgType2) label" ) );
+ assertEquals( new JavadocReference( Optional.empty(),
Optional.empty(), Optional.of( "member" ), Optional.of("label with spaces") ),
+ JavadocReference.parse( "#member label with spaces" ) );
Review Comment:
My bad, but this id/anchor contains spaces...?!
> Javadoc reference containing a link label with spaces are not detected
> ----------------------------------------------------------------------
>
> Key: MPLUGIN-443
> URL: https://issues.apache.org/jira/browse/MPLUGIN-443
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: API
> Affects Versions: 3.7.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: next-release
>
>
> For example the following link tag is not properly parsed:
> {code}
> {@link #member label with spaces}
> {code}
> and leads to the following exception
> {code}
> java.lang.IllegalArgumentException: Invalid format of javadoc reference:
> #member label with spaces
> at
> org.apache.maven.tools.plugin.javadoc.JavadocReference.parse(JavadocReference.java:74)
> ...
> {code}
> According to
> https://docs.oracle.com/en/java/javase/17/docs/specs/javadoc/doc-comment-spec.html#link
> this should be valid though as the link tag ends only with the '}'
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
