[ 
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636350#comment-17636350
 ] 

ASF GitHub Bot commented on MNG-7600:
-------------------------------------

michael-o commented on code in PR #876:
URL: https://github.com/apache/maven/pull/876#discussion_r1027358097


##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -309,6 +288,8 @@ else if ( !MAVEN_RESOLVER_TRANSPORT_AUTO.equals( transport 
) )
         mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
         mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
+        setupLocalRepositoryManager( request, session );

Review Comment:
   `setUp`. Noun "setup", verb "to set up"





> LocalRepositoryManager is created too early
> -------------------------------------------
>
>                 Key: MNG-7600
>                 URL: https://issues.apache.org/jira/browse/MNG-7600
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations fromĀ 
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during 
> {{LocalRepositoryManager}} preparation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to