[ 
https://issues.apache.org/jira/browse/MRESOLVER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633636#comment-17633636
 ] 

ASF GitHub Bot commented on MRESOLVER-291:
------------------------------------------

cstamas commented on PR #219:
URL: https://github.com/apache/maven-resolver/pull/219#issuecomment-1313377803

   ... and IMHO this is the correct way as it is now. As
   * we create one "client" (redisson/hz) per JVM
   * we have no session onClose (to close per session)
   * we'd actually risk OOM with hz if we'd do it per session, as it would add 
another node to cluster (2 nodes within same JVM)
   * fails early which is good: at component construction problems are revealed 
(ie, missing something from classpath) instead to "fail late"




> Undo MRESOLVER-284
> ------------------
>
>                 Key: MRESOLVER-291
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-291
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.1
>
>
> No semantics change, merely do not expect ctor config injection, use session 
> configuration params for everything as originally intended.
> The MRESOLVER-284 "breaking" part should be undone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to