[
https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630865#comment-17630865
]
ASF GitHub Bot commented on MNG-7590:
-------------------------------------
michael-o commented on code in PR #863:
URL: https://github.com/apache/maven/pull/863#discussion_r1017653958
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -313,6 +317,28 @@ else if ( !MAVEN_RESOLVER_TRANSPORT_AUTO.equals( transport
) )
return session;
}
+ private Map<?, ?> getConfigFromRequestProfiles( MavenExecutionRequest
request )
+ {
+
+ HashSet<String> activeProfileId = new HashSet<>(
request.getProfileActivation().getRequiredActiveProfileIds() );
+ activeProfileId.addAll(
request.getProfileActivation().getOptionalActiveProfileIds() );
+
+ return request.getProfiles().stream()
+ .filter( profile -> activeProfileId.contains( profile.getId() ) )
+ .map( ModelBase::getProperties )
+ .flatMap( properties -> properties.entrySet().stream() )
+ .filter( entry -> isPropertyForResolver( entry.getKey().toString()
) )
+ .collect(
+ Collectors.toMap( Map.Entry::getKey, Map.Entry::getValue, (
k1, k2 ) -> k2 ) );
+ }
+
+ private boolean isPropertyForResolver( String propertyName )
+ {
+ return propertyName != null
+ && ( propertyName.startsWith( "maven.resolver." ) ||
propertyName.startsWith( "aether." ) );
+ }
Review Comment:
@cstamas WDYT? I think the filter is not required here.
> Allow configure resolver by properties in settings.xml
> ------------------------------------------------------
>
> Key: MNG-7590
> URL: https://issues.apache.org/jira/browse/MNG-7590
> Project: Maven
> Issue Type: Improvement
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
>
> New Artifact Resolver has many useful configuration options, currently we
> only have the option to pass them as system or user properties.
> It will be useful to have possibility to provide them by properties in
> settings.xml to have whole configuration in one place.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
