mthmulders commented on code in PR #575:
URL: https://github.com/apache/maven-surefire/pull/575#discussion_r1009862231
##########
surefire-its/src/test/resources/surefire-1993-jpms-providing-modules/application/pom.xml:
##########
@@ -72,7 +72,7 @@
</executions>
<configuration>
<forkCount>1</forkCount>
- <forkMode>once</forkMode>
+ <forkCount>1</forkCount>
Review Comment:
Nit: this one seems a duplicate of the line above.
##########
surefire-its/src/test/resources/surefire-1041-exception-in-junit-runner/pom.xml:
##########
@@ -35,7 +35,7 @@
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <forkMode>once</forkMode>
+ <forkCount>1</forkCount>
Review Comment:
Nit: this one seems a duplicate of the line above.
##########
surefire-its/src/test/resources/surefire-1136-cwd-propagation-in-forked-mode/pom.xml:
##########
@@ -55,7 +55,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<!-- To override fork mode from parrent pom.xml -->
- <forkMode>once</forkMode>
+ <forkCount>1</forkCount>
Review Comment:
Nit: this one seems a duplicate of the line below.
##########
surefire-its/src/test/resources/surefire-1202-rerun-and-failfast/pom.xml:
##########
@@ -62,7 +62,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>${surefire.version}</version>
<configuration>
- <forkMode>once</forkMode>
+ <forkCount>1</forkCount>
Review Comment:
Nit: this one seems a duplicate of the line below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
