[ 
https://issues.apache.org/jira/browse/DOXIA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626213#comment-17626213
 ] 

Michael Osipov edited comment on DOXIA-667 at 10/30/22 11:00 AM:
-----------------------------------------------------------------

[~jdimeo], finally checked your sample. I can confirm this. First of all, can 
you provide a a full list of the "Unrecognized xhml5 tag..." output? I will 
check what can be added.

Now here is the explanation for the issue: For every HTML element to match 
there needs to be a sink event. For many, like input, option, etc. there are no 
events. As for blockquote, I have a local patch which works, need more input 
from you. As for thead, tbody, this is problemenatic since the events aren't 
there, but the way tables are structured in the output it is not ideal. I'd be 
willing to look into when the first list is complete, then this can be done 
also, maybe with a sink change, e.g,, {{Sink#tableHeaderRows()}} and 
{{Sink#tableHeaderRows_()}}.

[~hboutemy], WDYT?

Note: The current XHML5 Sink does not emit thead and tbody, but this can be 
changed to make it consistent.


was (Author: michael-o):
[~jdimeo], finally checked your sample. I can confirm this. First of all, can 
you provide a a full list of the "Unrecognized xhml5 tag..." output? I will 
check what can be added.

Now here is the explanation for the issue: For every HTML element to match 
there needs to be a sink event. For many, like input, option, etc. there are no 
events. As for blockquote, I have a local patch which works, need more input 
from you. As for thead, tbody, this is problemenatic since the events aren't 
there, but the way tables are structured in the output it is not ideal. I'd be 
willing to look into when the first list is complete, then this can be done 
also, maybe with a sink change, e.g,, {{Sink#tableHeaderRows()}} and 
{{Sink#tableHeaderRows_()}}.

[~hboutemy], WDYT?

> Add <summary> and <details> to recognized tag list
> --------------------------------------------------
>
>                 Key: DOXIA-667
>                 URL: https://issues.apache.org/jira/browse/DOXIA-667
>             Project: Maven Doxia
>          Issue Type: Improvement
>          Components: Module - Xhtml
>            Reporter: John Dimeo
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M4
>
>         Attachments: hw_age.md, image-2022-10-20-14-24-40-888.png
>
>
> I see both {{<details>}} and {{<summary>}} here:
> [maven-doxia/HtmlMarkup.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java]
> is there a reason it's not part of {{ALL_TAGS}} here?
> [https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java#L42]
> I'm getting this error:
> [maven-doxia/Xhtml5BaseSink.java at master · apache/maven-doxia 
> (github.com)|https://github.com/apache/maven-doxia/blob/master/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L2206]
> when I try to use details/disclosure in a Markdown file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to