gnodet commented on code in PR #167:
URL:
https://github.com/apache/maven-plugin-tools/pull/167#discussion_r1007818383
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/converter/JavaClassConverterContext.java:
##########
@@ -81,13 +80,6 @@ public JavaClassConverterContext( JavaClass mojoClass,
JavaClass declaringClass,
Map<String, MojoAnnotatedClass>
mojoAnnotatedClasses,
JavadocLinkGenerator linkGenerator, int
lineNumber )
{
- if ( !( mojoClass.getJavaClassLibrary() instanceof SourceLibrary )
Review Comment:
Well, in my case, the parent class was not part of the module being built,
and the `declaringClass.getJavaClassLibrary()` is an instance of
`ClassLoaderLibrary`.
The generation will still work, even if some links can not be resolved. But
the plugin as a whole can not fail for this reason. And it's a valid use case,
so even a warning may be too much, unless it can be disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
