gnodet commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288069391
> LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build.... > And it's a bit confusing as when testing this pom with m-war-p, `checkstyle:check` is passing but not `spotless:check' I've disabled the checkstyle checks that could conflict with the ones checked by spotless, so what you see is expected. The remaining checkstyle checks should be related to non stylistic issues: naming, ordering, javadoc, method/file length, modifiers ordering, inner assignment, magic numbers, etc... So those checks can not really be fixed without refactoring the code. Makes more sense ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
