[GitHub] [maven-plugin-tools] bmarwell commented on a diff in pull request #152: [MPLUGIN-426] add @Description annotation

[GitBox]

bmarwell commented on code in PR #152:
URL: https://github.com/apache/maven-plugin-tools/pull/152#discussion_r996494652


##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java:
##########
@@ -288,16 +288,19 @@ protected void populateDataFromJavadoc( Map<String, 
MojoAnnotatedClass> mojoAnno
             MojoAnnotationContent mojoAnnotationContent = 
entry.getValue().getMojo();
             if ( mojoAnnotationContent != null )
             {
-                mojoAnnotationContent.setDescription( javaClass.getComment() );
+                if ( StringUtils.isEmpty( 
mojoAnnotationContent.getDescription() ) )
+                {
+                    mojoAnnotationContent.setDescription( 
javaClass.getComment() );
+                }
 
                 DocletTag since = findInClassHierarchy( javaClass, "since" );
-                if ( since != null )
+                if ( since != null && StringUtils.isEmpty( 
mojoAnnotationContent.getSince() ) )
                 {
                     mojoAnnotationContent.setSince( since.getValue() );
                 }
 
                 DocletTag deprecated = findInClassHierarchy( javaClass, 
"deprecated" );
-                if ( deprecated != null )
+                if ( deprecated != null && StringUtils.isEmpty( 
mojoAnnotationContent.getDeprecated() ) )
                 {

Review Comment:
   New behaviour (compatible): Only set from javadoc annotation if not already 
set by Java annotation..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org