[GitHub] [maven-resolver] cstamas commented on a diff in pull request #194: [MRESOLVER-273] More compact filesystem friendly mapper

[GitBox]

cstamas commented on code in PR #194:
URL: https://github.com/apache/maven-resolver/pull/194#discussion_r981139587


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/StaticNameMapper.java:
##########
@@ -25,24 +25,31 @@
 import org.eclipse.aether.RepositorySystemSession;
 import org.eclipse.aether.artifact.Artifact;
 import org.eclipse.aether.metadata.Metadata;
-import org.eclipse.aether.util.ConfigUtils;
 
 /**
  * Static {@link NameMapper}, always assigns one same name, effectively 
becoming equivalent to "static" sync context:
  * always maps ANY input to same name.
  */
 public class StaticNameMapper implements NameMapper
 {
-    /**
-     * Configuration property to pass in static name
-     */
-    private static final String CONFIG_PROP_NAME = 
"aether.syncContext.named.static.name";
+    @Override
+    public boolean isFileSystemFriendly()
+    {
+        return true;
+    }
 
     @Override
     public Collection<String> nameLocks( final RepositorySystemSession session,
                                          final Collection<? extends Artifact> 
artifacts,
                                          final Collection<? extends Metadata> 
metadatas )
     {
-        return Collections.singletonList( ConfigUtils.getString( session, 
"static", CONFIG_PROP_NAME ) );
+        if ( ( artifacts != null && !artifacts.isEmpty() ) || ( metadatas != 
null && !metadatas.isEmpty() ) )
+        {
+            return Collections.singletonList( "static" );
+        }
+        else
+        {
+            return Collections.emptyList();

Review Comment:
   yup, static misbehaved as for that matter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org